Allow @transform directive to be applied to properties.
#617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
force-pushed
the
transform_on_properties
branch
2 times, most recently
from
56521dc to
ffcd417
Compare
This lays the groundwork for `@fold @Transform(op: "count")` followed by more `@transform` operations before a subsequent `@filter`.
…r infra. (#623) * Initial draft of the data structures for transforming values. * Update error message generation and tests.
obi1kenobi
force-pushed
the
transform_on_properties
branch
from
ffcd417 to
387c1ff
Compare
Only works for zero-arg transform operators, only on properties, and not tested currently. Required some noticeable refactors, and I needed an intermediate checkpoint.
First passing end-to-end test featuring `@transform` on a property!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.