Add external types exposed through public api check for CI

[u9g]

No description provided.

[u9g]

Setup closely mirrors https://github.com/awslabs/cargo-check-external-types/blame/main/.github/workflows/ci.yml#L110

[obi1kenobi]

This is going to rebuild on every PR update, which is going to be horrifically slow. The tool's doesn't offer prebuilt binaries, and it's not part of cargo-quickinstall's prebuilt list either.

Almost tempted to not use it over this, to be honest.

What do you think?

[u9g]

I'm not super upset over it as it takes approximately the same 2 minutes to run the tests. We can also either ask them to offer prebuilt binaries or just build it ourselves on every commit in a different repo similar to what cargo-quickinstall does.

Is there any way we can ask them to add it to cargo-quickinstall?

[obi1kenobi]

Not sure, check that project's repo? There might be a way to request new crates to be added.

…

On Sat, Aug 5, 2023, 11:08 PM u9g ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .github/workflows/ci.yml <#434 (comment)>: > + steps: + - name: Checkout + uses: ***@***.*** + with: + persist-credentials: false + + - name: Install rust + uses: ***@***.*** + with: + toolchain: "nightly-2023-05-31" + + - uses: ***@***.*** + + - name: Check Exported API + run: | + cargo install --locked cargo-check-external-types I'm not super upset over it as it takes approximately the same 2 minutes to run the tests. We can also either ask them to offer prebuilt binaries or just build it ourselves on every commit in a different repo similar to what cargo-quickinstall does. Is there any way we can ask them to add it to cargo-quickinstall? — Reply to this email directly, view it on GitHub <#434 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5MSSYID2WSI7IAFOL53TXT4DDTANCNFSM6AAAAAA3FTEENM> . You are receiving this because your review was requested.Message ID: ***@***.***>