Per role quote policies by martintomazic · Pull Request #6471 · oasisprotocol/oasis-core

martintomazic · 2026-03-04T11:27:10Z

Replaces #6410 following simplifications agreed in the #6387.

Considerations:

Can be simplified further: Per role quote policies #6471 (comment)
We can make the runtime sign the role information as part of the attestation (similar to the node ID), so if the host lied about its role during RHP it can be later verified.
- New RHP method, technically should not be breaking, add role as part of the hash structure. Breaking?
Architectural smell exposed: Support for compute runtime quote policy #6387 (comment).
e2e test or at least sanity that everything is wired correctly and access gated.

netlify · 2026-03-04T11:27:16Z

✅ Deploy Preview for oasisprotocol-oasis-core canceled.

Name	Link
🔨 Latest commit	`efbc5bc`
🔍 Latest deploy log	https://app.netlify.com/projects/oasisprotocol-oasis-core/deploys/69a97a06514b0c00080e3c3f

martintomazic · 2026-03-04T11:30:46Z

go/common/node/sgx.go

+	// PerRolePolicy defines additional role specific quote policies, that overwrite
+	// Policy when node with these roles does an attestation.
+	//
+	// A valid entry is for either [RoleComputeWorker] or [RoleObserver]. Single entry
+	// should not encode multiple roles.
+	PerRolePolicy map[RolesMask]quote.Policy `json:"per_role_policy,omitempty"`


Given that:

We only allow it for observer and compute roles

Keymanager runtime kind does not allow it

We don't see discriminating observer/compute access, as they both have access to same secrets,

How about simplifying things further and instead have ComputePolicy *quote.Policy that only applies for the compute runtimes for the observer/compute roles.

This should simplify assumptions, tests, comments, validations and avoid the need for new "at most one runtime sgx role" invariant.

That makes sense to me, no need to have a general map that introduces unnecessary complexity.

martintomazic · 2026-03-04T11:31:58Z

go/common/node/node.go


 // Verify verifies the node's TEE capabilities, at the provided timestamp and height.
-func (c *CapabilityTEE) Verify(teeCfg *TEEFeatures, ts time.Time, height uint64, constraints []byte, nodeID signature.PublicKey, isFeatureVersion242 bool) error {
+func (c *CapabilityTEE) Verify(teeCfg *TEEFeatures, ts time.Time, height uint64, constraints []byte, nodeID signature.PublicKey, nodeRoles RolesMask, isFeatureVersion242 bool) error {


NIT: All this functions should accept validation options structs?

Agreed, this is why we introduced the TEEFeatures struct a while back (which is now somewhat obsolete due to the use of feature versions). There are already too many parameters everywhere.

martintomazic · 2026-03-04T11:33:28Z

go/common/node/node.go


 // ValidateBasic performs basic descriptor validity checks.
-func (n *Node) ValidateBasic(strictVersion bool) error {
+func (n *Node) ValidateBasic(strictVersion bool, isFeatureVersion242 bool) error {


Nit: There is not such thing as ValidateBasic. Only Validate with clear invariants and tests for the invariants the Validate will check. Moreover, the validation params should probably be passes as part of the validation options struct. Possibly this check could also be part of the VerifyRegisterNodeArgs directly which avoids some additional changes, but feels off there.

martintomazic · 2026-03-04T11:39:22Z

go/registry/api/runtime.go

+			if r.Kind == KindKeyManager && cs.PerRolePolicy != nil {
+				return fmt.Errorf("%w: invalid SGX TEE constraints: keymanager runtime with per-role policies", ErrInvalidArgument)
+			}


Or make it part of the ValidateBasic, again this should be Validate with validate option struct so that it is clear what we are validating.

martintomazic · 2026-03-05T12:24:18Z

go/common/node/sgx.go

+// PolicyFor returns a matching per-role policy when present, or otherwise falls back to the default policy.
+//
+// This function expects role mask that has at most one runtime SGX role.
+func (s *SGXConstraints) PolicyFor(roles RolesMask) *quote.Policy {


It would be so much nicer if we would have RuntimeSGXRole type so that comments, invariants and corner cases are instead captured by the type system. Even per role policies could use this type as a key. Not sure there is practical / idiomatic way to achieve this in go.

martintomazic · 2026-03-05T13:11:22Z

Ready for the first round of reviews.

Please focus on the considerations outlined in the context and existing threads.

Given motivation and intended usage of this feature, I am in favor of replacing per-role policies with a single compute runtime policy that applies to both observer and compute roles.

kostko · 2026-03-11T06:43:55Z

.changelog/6387.internal.0.md

@@ -0,0 +1,4 @@
+go/registry/api: Allow at most one runtime SGX role


Suggested change

go/registry/api: Allow at most one runtime SGX role

go/registry/api: Allow at most one runtime TEE role

kostko · 2026-03-11T06:44:23Z

go/common/node/node.go


+// AtMostOneRuntimeSGXRole returns true when RoleMask has at most one SGX runtime role.
+func (m RolesMask) AtMostOneRuntimeSGXRole() bool {
+	sgxRoles := m & (RoleComputeWorker | RoleObserver | RoleKeyManager)


The set of roles should be a top-level constant. Also note that these are not SGX-specific so you should use "TEE" instead of "SGX".

kostko · 2026-03-11T06:47:20Z

go/common/node/node.go


 // Verify verifies the node's TEE capabilities, at the provided timestamp and height.
-func (c *CapabilityTEE) Verify(teeCfg *TEEFeatures, ts time.Time, height uint64, constraints []byte, nodeID signature.PublicKey, isFeatureVersion242 bool) error {
+func (c *CapabilityTEE) Verify(teeCfg *TEEFeatures, ts time.Time, height uint64, constraints []byte, nodeID signature.PublicKey, nodeRoles RolesMask, isFeatureVersion242 bool) error {


Agreed, this is why we introduced the TEEFeatures struct a while back (which is now somewhat obsolete due to the use of feature versions). There are already too many parameters everywhere.

kostko · 2026-03-11T06:51:18Z

go/common/node/sgx.go

+	// PerRolePolicy defines additional role specific quote policies, that overwrite
+	// Policy when node with these roles does an attestation.
+	//
+	// A valid entry is for either [RoleComputeWorker] or [RoleObserver]. Single entry
+	// should not encode multiple roles.
+	PerRolePolicy map[RolesMask]quote.Policy `json:"per_role_policy,omitempty"`


That makes sense to me, no need to have a general map that introduces unnecessary complexity.

go/registry: Allow only single runtime sgx role after 24.2

5419d2b

martintomazic commented Mar 4, 2026

View reviewed changes

martintomazic force-pushed the martin/feature/per-role-quote-policies-v2 branch from 64ef9a0 to a790a46 Compare March 4, 2026 11:35

martintomazic commented Mar 4, 2026

View reviewed changes

martintomazic linked an issue Mar 5, 2026 that may be closed by this pull request

Support for compute runtime quote policy #6387

Open

martintomazic commented Mar 5, 2026

View reviewed changes

martintomazic added 2 commits March 5, 2026 13:39

go/common/node: Add per-role quote policies to SgxConstraints

8ef5d63

go: Validate attestation against per role policies prior early

efbc5bc

martintomazic force-pushed the martin/feature/per-role-quote-policies-v2 branch from a790a46 to efbc5bc Compare March 5, 2026 12:41

martintomazic marked this pull request as ready for review March 5, 2026 13:11

martintomazic requested review from kostko, peternose and ptrus as code owners March 5, 2026 13:11

kostko reviewed Mar 11, 2026

View reviewed changes

martintomazic mentioned this pull request Mar 11, 2026

Support for compute runtime quote policy #6387

Open

		@@ -0,0 +1,4 @@
		go/registry/api: Allow at most one runtime SGX role

Conversation

martintomazic commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for oasisprotocol-oasis-core canceled.

Uh oh!

martintomazic Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

martintomazic Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

martintomazic Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

martintomazic commented Mar 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

martintomazic commented Mar 4, 2026 •

edited

Loading

netlify bot commented Mar 4, 2026 •

edited

Loading

martintomazic Mar 4, 2026 •

edited

Loading

martintomazic Mar 4, 2026 •

edited

Loading

martintomazic Mar 5, 2026 •

edited

Loading