go/consensus/cometbft/abci/system: Change events root#6289
go/consensus/cometbft/abci/system: Change events root#6289
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
force-pushed
the
peternose/breaking/events-root
branch
3 times, most recently
from
f4a7992 to
4023dbf
Compare
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
peternose
force-pushed
the
peternose/breaking/events-root
branch
from
4023dbf to
f9c9a08
Compare
| return nil | ||
| } | ||
| return merkle.RootHash(provableEvents), nil | ||
| return cmttypes.NewResults(mux.state.proposal.resultsDeliverTx).Hash() |
There was a problem hiding this comment.
Sorry, my answer was wrong. What I meant was that since NewResults strips all "non-deterministic" fields, no events can be verified using this hash. That holds also for events from DeliverTx. However, you can verify transaction results but only fields Code, Data, GasWanted, GasUsed.
To prove events, one must use our Merkle root, which will change if we change events. Observe that this root doesn't hold information in which phase of the block execution event occurred (begin, ..., end) as all current consumers don't care about that, and the implementation simplifies as we don't need to create root for every phase.
peternose
force-pushed
the
peternose/breaking/events-root
branch
from
f9c9a08 to
1113268
Compare
The events root in block metadata system transaction now includes all events, not just provable ones.
The results hash was added to the block metadata system transaction so that stateless clients can partially verify the latest block’s results.
peternose
force-pushed
the
peternose/breaking/events-root
branch
from
1113268 to
5b2ad42
Compare
kostko
left a comment
kostko
left a comment
There was a problem hiding this comment.
Would be good to validate this does not introduce any issues on Testnet and Mainnet.
2 participants
No description provided.