[RHELC-1760] Make post-conversion analysis summary clearer #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 72 72
Lines 5178 5178
Branches 895 895
=======================================
Hits 4977 4977
Misses 119 119
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bocekm
added
tests/skip
Venefilyn
approved these changes
Nov 25, 2024
Venefilyn
added
tests/sanity
bocekm
changed the title
hosekadam
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Looks good. Just this will need some changes in integration tests as somewhere is No changes needed expected e.g.:
/tests/integration/tier0/non-destructive/assessment-report/successful_report or /tests/integration/tier0/non-destructive/assessment-report/failures_and_skips_in_report
bocekm
force-pushed
the
clearer-post-conversion-summary-line
branch
from
527cb44 to
5a51b05
Compare
I was not sure what "No changes needed" means (changes to do by the tool or myself?). IMHO "No action required" is clearer.
bocekm
force-pushed
the
clearer-post-conversion-summary-line
branch
from
5a51b05 to
888bb9f
Compare
|
/packit test --labels sanity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not sure what "No changes needed" means (changes to do by the tool or myself?).
IMHO "No action required" is clearer.
Jira Issues:
Checklist
[RHELC-]or[HMS-]is part of the PR titleRelease Pendingif relevant