CI: fix GitHub Pages deployment environment protection error #3464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the deploy-pages job from doc-and-spec to fix the error: "Branch refs/pull/*/merge is not allowed to deploy to github-pages due to environment protection rules" The issue was that the `environment: github-pages` block was set at the job level for doc-and-spec, which applies to all matrix runs including PRs. GitHub's environment protection rules then blocked the job even though the actual deploy steps only ran on master. The fix creates a separate deploy-pages job that: - Only runs on push to master (job-level condition) - Has the github-pages environment declaration - Depends on doc-and-spec to ensure tests pass first - Rebuilds the book and rustdoc for deployment
iostat
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the error on PRs:
Problem
The
doc-and-specjob hadenvironment: github-pagesset at the job level, which applies to all matrix runs including PRs. GitHub's environment protection rules then blocked the entire job, even though the actual deploy steps only ran conditionally on push to master.Solution
Split the deployment into a separate
deploy-pagesjob that:ifcondition)github-pagesenvironment declarationdoc-and-specto ensure all tests pass firstThis ensures the environment protection rules only apply when actually deploying to GitHub Pages.
Test plan