feat: Allow UTC-aware datetimes in Epoch.fromdatetime

[ChristopherRabotin]

The Epoch.fromdatetime function now accepts Python datetime objects that are timezone-aware, as long as the timezone is UTC. Previously, any timezone-aware datetime would be rejected.

This change modifies the function to check the utcoffset of the datetime object's tzinfo. If the offset is zero (i.e., UTC) or if the datetime is naive, the conversion proceeds. Otherwise, an error is raised.

A new test case has been added to tests/python/test_epoch.py to verify this new behavior.

[gemini-code-assist]

Summary of Changes

Hello @ChristopherRabotin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Epoch.fromdatetime method to be more accommodating of Python's datetime objects. It introduces the ability to parse UTC-aware datetimes directly, enhancing usability while maintaining strictness by rejecting datetimes with non-UTC timezones. This change improves the robustness of time conversions between Python and the underlying Rust library.

Highlights

• Enhanced Epoch.fromdatetime functionality: The Epoch.fromdatetime method now supports Python datetime objects that are timezone-aware, specifically if their timezone is UTC. Previously, any timezone-aware datetime would result in an error.
• Strict UTC enforcement: The function now explicitly checks the utcoffset of the provided datetime object's tzinfo. Conversion proceeds only if the offset is zero (indicating UTC) or if the datetime is naive. Any other timezone offset will still raise an error.
• Improved Python error handling: An impl From<pyo3::PyErr> for HifitimeError has been added, simplifying the conversion of Python errors into HifitimeError within the Rust codebase when the Python feature is enabled.
• New test cases: Comprehensive test cases have been added to tests/python/test_epoch.py to verify the correct behavior for naive, UTC-aware, and non-UTC-aware datetime objects, ensuring the new logic works as intended.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.72%. Comparing base (99ff044) to head (1f2cfd8).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files          24       24           
  Lines        3578     3578           
=======================================
  Hits         2960     2960           
  Misses        618      618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request is a great enhancement, allowing Epoch.fromdatetime to handle UTC-aware datetime objects. The implementation in Rust and the new tests in Python are mostly on the right track. However, I've found a couple of high-severity issues. There's a compilation error in the Rust code due to an outdated API call, and the new Python test for non-UTC timezones is broken. I've provided detailed comments and suggestions to fix these issues.