Skip to content

Fix conversion from Ephemeris Time to datetime #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristopherRabotin merged 2 commits into from
Oct 2, 2025
Merged

Fix conversion from Ephemeris Time to datetime #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
809522b
add test for ephemeris time to python datetime conversion
J-Westin Oct 2, 2025
7d5ad9a
convert duration to utc in todatetime method
J-Westin Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/epoch/python.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,7 @@ impl Epoch {
/// :rtype: datetime.datetime
fn todatetime<'py>(&self, py: Python<'py>) -> Result<Bound<'py, PyDateTime>, PyErr> {
let (y, mm, dd, hh, min, s, nanos) =
Epoch::compute_gregorian(self.duration, TimeScale::UTC);
Epoch::compute_gregorian(self.to_utc_duration(), TimeScale::UTC);

let datetime = PyDateTime::new(py, y, mm, dd, hh, min, s, nanos / 1_000, None)?;

Expand Down
15 changes: 15 additions & 0 deletions tests/python/test_epoch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,21 @@ def test_interop():
)


def test_ephemeris_time_todatetime():
"""
Test for the issue highlighted by [issue 421][issue-421].

[issue-421]: https://github.com/nyx-space/hifitime/issues/421
"""
test_epoch = Epoch("2025-03-07T12:01:09.185475585 ET")

actual_datetime = test_epoch.todatetime()
expected_datetime = datetime(year=2025, month=3, day=7, hour=12, minute=0)

# Before fixing, `actual_datetime = (1925, 3, 8, 0, 1, 9, 185475)`.
assert actual_datetime == expected_datetime


def test_polynomial():
t_gpst = Epoch.from_gregorian(2020, 1, 1, 0, 0, 0, 0, TimeScale.GPST)

Expand Down