359 replace reqwest with ureq -- Follow on to #360 #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings
This commit significantly expands the hifitime Python bindings:
1. **Expose `Polynomial`:**
* Makes the `Polynomial` struct available in Python, crucial for precise time scale conversions (e.g., modeling GPST-UTC differences).
* Provides Python-friendly classmethod constructors (`from_constant_offset`, `from_constant_offset_nanoseconds`, `from_offset_and_rate`, `from_offset_rate_nanoseconds`).
* Exposes the `correction_duration` method.
* Adds a `__str__` representation.
* Includes Python tests validating `Polynomial` creation and its use within `Epoch.precise_timescale_conversion`.
2. **Expose `Weekday`:**
* Makes the `Weekday` enum available in Python.
* Enables usage like `epoch.next(Weekday.Monday)`.
* Adds a corresponding Python test.
3. **Enhance `Epoch` Bindings:**
* Adds read-only `duration` and `time_scale` properties to the Python `Epoch` class for easier introspection.
* Updates internal PyO3 API calls (`PyDateTime::new`, `get_tzinfo`) for compatibility or best practices.
These changes allow Python users to leverage more advanced features of hifitime, particularly for high-precision time scale adjustments and date calculations involving weekdays, directly from Python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #360 for the
ureqdetails.I've usurped this PR to cleanup some Python exports, summarized by Gemini as follows:
Expose
Polynomial:Polynomialstruct available in Python, crucial for precise time scale conversions (e.g., modeling GPST-UTC differences).from_constant_offset,from_constant_offset_nanoseconds,from_offset_and_rate,from_offset_rate_nanoseconds).correction_durationmethod.__str__representation.Polynomialcreation and its use withinEpoch.precise_timescale_conversion.Expose
Weekday:Weekdayenum available in Python.epoch.next(Weekday.Monday).Enhance
EpochBindings:durationandtime_scaleproperties to the PythonEpochclass for easier introspection.PyDateTime::new,get_tzinfo) for compatibility or best practices.These changes allow Python users to leverage more advanced features of hifitime, particularly for high-precision time scale adjustments and date calculations involving weekdays, directly from Python.