Skip to content

Namespace default cache dir by model_type. #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeswan merged 1 commit into from
Dec 21, 2020
Merged

Namespace default cache dir by model_type. #1246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jiant/proj/simple/runscript.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def run_simple(args: RunConfiguration, with_continue: bool = False):
phases_to_do = []
for phase, phase_task_list in phase_task_dict.items():
if task_name in phase_task_list and not os.path.exists(
os.path.join(args.exp_dir, "cache", task_name, phase)
os.path.join(args.exp_dir, "cache", args.model_type, task_name, phase)
):
phases_to_do.append(phase)
if not phases_to_do:
Expand All @@ -152,7 +152,7 @@ def run_simple(args: RunConfiguration, with_continue: bool = False):
model_tokenizer_path=os.path.join(
model_cache_path, args.model_type, "tokenizer"
),
output_dir=os.path.join(args.exp_dir, "cache", task_name),
output_dir=os.path.join(args.exp_dir, "cache", args.model_type, task_name),
phases=phases_to_do,
# TODO: Need a strategy for task-specific max_seq_length issues (issue #1176)
max_seq_length=args.max_seq_length,
Expand All @@ -166,7 +166,7 @@ def run_simple(args: RunConfiguration, with_continue: bool = False):
# number of moving parts.
jiant_task_container_config = configurator.SimpleAPIMultiTaskConfigurator(
task_config_base_path=os.path.join(args.data_dir, "configs"),
task_cache_base_path=os.path.join(args.exp_dir, "cache"),
task_cache_base_path=os.path.join(args.exp_dir, "cache", args.model_type),
train_task_name_list=args.train_tasks,
val_task_name_list=args.val_tasks,
test_task_name_list=args.test_tasks,
Expand Down