Adds Fever NLI task and data downloader#1215
Merged
jeswan merged 9 commits intonyu-mll:masterfrom Nov 5, 2020
Merged
Conversation
Conflicts: jiant/scripts/download_data/datasets/files_tasks.py
|
Hello @angie-chen55! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
You can repair most issues by installing black and running: |
jeswan
requested changes
Oct 26, 2020
Collaborator
jeswan
left a comment
jeswan
left a comment
There was a problem hiding this comment.
Thanks for this PR! Please add step 4 of https://github.com/nyu-mll/jiant/blob/master/guides/tasks/adding_tasks.md and address the formatting error.
jeswan
approved these changes
Oct 29, 2020
leo-liuzy
pushed a commit
to leo-liuzy/dynamic_jiant
that referenced
this pull request
Nov 11, 2020
* Implement task and add downloader for Fever NLI Co-authored-by: jeswan <57466294+jeswan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.