Add documentation step to add task guide#1154
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1154 +/- ##
=======================================
Coverage 56.91% 56.91%
=======================================
Files 133 133
Lines 9696 9696
=======================================
Hits 5518 5518
Misses 4178 4178 Continue to review full report at Codecov.
|
zphang
approved these changes
Oct 16, 2020
Collaborator
|
We should mention adding to the downloader as well. (Also, we need to clean up the organization of constants for task names for the downloader - they're in two very separate files currently.) (Even more ambitiously, we could consider moving the downloading (+eval) logic to the task files themselves.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a step to the Add a task guide to document the added task in the supported tasks chart.
@wh629 Can you check I correctly documented
arct? Also, please add the task in #1152 to the task chart.