Skip to content

setup.py fix#1141

Merged
jeswan merged 4 commits intonyu-mll:masterfrom
zphang:setup
Oct 9, 2020
Merged

setup.py fix#1141
jeswan merged 4 commits intonyu-mll:masterfrom
zphang:setup

Conversation

@zphang
Copy link
Collaborator

@zphang zphang commented Oct 9, 2020

No description provided.

@pep8speaks
Copy link

pep8speaks commented Oct 9, 2020

Hello @zphang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2:101: E501 line too long (118 > 100 characters)
Line 26:101: E501 line too long (101 > 100 characters)
Line 39:101: E501 line too long (106 > 100 characters)
Line 47:101: E501 line too long (126 > 100 characters)
Line 90:2: W292 no newline at end of file

You can repair most issues by installing black and running: black -l 100 ./*. If you contribute often, have a look at the 'Contributing' section of the README for instructions on doing this automatically.

Comment last updated at 2020-10-09 00:28:34 UTC

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #1141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1141   +/-   ##
=======================================
  Coverage   56.87%   56.87%           
=======================================
  Files         132      132           
  Lines        9652     9652           
=======================================
  Hits         5490     5490           
  Misses       4162     4162           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135355d...bde437b. Read the comment docs.

@jeswan jeswan merged commit 02bb070 into nyu-mll:master Oct 9, 2020
leo-liuzy pushed a commit to leo-liuzy/dynamic_jiant that referenced this pull request Nov 11, 2020
* setup.py fix

* Setup docs

Co-authored-by: jeswan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants