Adding SingleTaskConfigurator, some cleanup#1135
Merged
zphang merged 9 commits intonyu-mll:masterfrom Oct 7, 2020
Merged
Conversation
jeswan
reviewed
Oct 7, 2020
|
|
||
| @Registry.register | ||
| @zconf.run_config | ||
| class SingleTaskConfigurator(zconf.RunConfig): |
Collaborator
There was a problem hiding this comment.
Would prefer to not duplicate everything here. Can the configurators be combined?
Collaborator
Author
There was a problem hiding this comment.
This is meant to be a much more streamlined configurator since it only supports one task - the multi-task configurator has a lot more complexity because it needs to deal with potentially different tasks in different phases.
Codecov Report
@@ Coverage Diff @@
## master #1135 +/- ##
==========================================
- Coverage 57.04% 56.87% -0.17%
==========================================
Files 132 132
Lines 9584 9652 +68
==========================================
+ Hits 5467 5490 +23
- Misses 4117 4162 +45
Continue to review full report at Codecov.
|
jeswan
approved these changes
Oct 7, 2020
leo-liuzy
pushed a commit
to leo-liuzy/dynamic_jiant
that referenced
this pull request
Nov 11, 2020
* Colab fix * single-task configurator * configurator * blake Co-authored-by: jeswan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.