tweak + small new test #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgergen
approved these changes
Nov 8, 2020
bgergen
added a commit
that referenced
this pull request
Nov 11, 2020
* Copy additional functionality to hook * Call hook from decorator * Fix props issue & tests * Remove top-level hook warning * Unskip & update hook tests * Remove lint warnings * Remove extraneous loc * Move core functionality into separate hook * Clean up tests * Move ReactTrackingContext into separate file, update useTracking tests * Update src/__tests__/hooks.test.js Co-authored-by: Jeremy Gayed <[email protected]> * Update tests * More test updates * Fix lint error * Store data & options in refs * Update hooks test to call dispatch mock Co-authored-by: Jeremy Gayed <[email protected]> * Update tests, fix memoization bug * tweak + small new test (#170) Co-authored-by: Jeremy Gayed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed one of the tests never got updated to the hooks API, plus added another minor test
NOTE: This PR is going into
expanded-hooks-apibranch.