Failing hooks test to code against #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgergen
approved these changes
Oct 19, 2020
Collaborator
bgergen
left a comment
bgergen
left a comment
There was a problem hiding this comment.
This looks great! Some interesting things to think about in the todos re: the API design, but this definitely feels like enough to get started coding against.
| }; | ||
|
|
||
| const Page = () => { | ||
| useTracking({ page: 'Page' }); |
Collaborator
There was a problem hiding this comment.
How is this different from the 2 tests above this one, where it does dispatch a pageview event?
Collaborator
Author
There was a problem hiding this comment.
Ah good catch, I think this was a bad copy pasta, the process function should no-op to match up with the corresponding e2e test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial PR to introduce some failing tests (skipped) to code against for #138