Skip to content

Conversation

@dwelch2344
Copy link
Contributor

@dwelch2344 dwelch2344 commented Jun 21, 2024

A simple POC to build from, but wanted to open for feedback on #3366

@dwelch2344 dwelch2344 changed the title [New] Add support for NVM_AUTH_HEADER env var Auth support for NVM_AUTH_HEADER env var Jun 21, 2024
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It'll need some tests ofc.

@dwelch2344 dwelch2344 marked this pull request as ready for review June 28, 2024 15:19
@ljharb ljharb added installing node Issues with installing node/io.js versions. feature requests I want a new feature in nvm! labels Jun 29, 2024
@ljharb ljharb force-pushed the auth_header branch 2 times, most recently from 2bf3f9a to 78e9f45 Compare July 1, 2024 20:53
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ljharb ljharb closed this Jul 4, 2024
@ljharb ljharb reopened this Jul 4, 2024
@ljharb ljharb force-pushed the auth_header branch 5 times, most recently from 016af9d to 8fcd4ab Compare July 6, 2024 19:13
@ljharb ljharb force-pushed the auth_header branch 2 times, most recently from 981d19c to 29331ff Compare July 23, 2024 02:17
@ljharb ljharb closed this Jul 26, 2024
@ljharb ljharb reopened this Jul 26, 2024
@CDIT-BE
Copy link

CDIT-BE commented Oct 21, 2024

Has this been tested for basic authentication using username:password?

I'm trying to use NVM_AUTH_HEADER to authenticate to a proxy repo in Nexus and Nexus does not use a bearer token.

@ljharb
Copy link
Member

ljharb commented Oct 21, 2024

I'd love to get a PR with a test case for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature requests I want a new feature in nvm! installing node Issues with installing node/io.js versions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants