added WSL Troubleshooting and provided a solution to a common problem (fixed typos) #2961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve host: raw.githubusercontent.com Fixes nvm-sh#2958.
Member
|
oof, each PR opened is a permanent ref on the repo :-/ let's keep this one open and I can help you resolve the issue. |
ljharb
approved these changes
Dec 1, 2022
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Thanks, this is great!
Tests are broken on master right now, but once fixed, I'll rebase and land this.
ljharb
added
OS: windows
installing node
Contributor
Author
|
How come my name isn't showing up on the contributors list? |
Member
|
I'm not sure - Github shows you as the commit author. If you mean the contributors list on the repo that's capped at 100 contributors, there'll be lots of contributors with a single commit that don't show up there - since the last 3 people have 1 commit, you'd need 2 commits to guarantee showing up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully this fixes the indent issue for the test I was failing in my last PR
closes #2958