[Fix] nvm install error unknown condition: -ne
#2915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nvm-sh#2914 Co-authored-by: epoweripione <[email protected]> Co-authored-by: Jordan Harband <[email protected]>
ljharb
requested changes
Oct 15, 2022
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Rather than just add this default, I'd prefer to figure out which code branch is failing to set the EXIT_CODE properly.
|
I confirm it fixes the issue but @ljharb is right: that is not fixing the root cause and why a not properly initialized variable ends up in a condition check. |
ljharb
approved these changes
Oct 15, 2022
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
k, i've figured it out - the nvm use result wasn't being captured, and nvm install --lts was triggering that.
Will land and release this soon.
|
I'm still getting this on 0.39.2 ? |
Member
|
That’s because this fix isn’t in v0.39.2. |
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #2914