[readme] optimize calling of nvm version in zsh
#2874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Aug 31, 2022
ljharb
approved these changes
Aug 31, 2022
Looks like I pushed a new commit seconds before you approved. Do you want me to clean up the commits on this PR or will you squash merge? |
|
i'll rebase it when it's time, no worries :-) |
ljharb
force-pushed
the
zsh-hook-update
branch
2 times, most recently
from
2230416 to
4893128
Compare
carlosala
added a commit
to ohmyzsh/ohmyzsh
that referenced
this pull request
Mar 4, 2024
Now we only call `nvm version` in case we changed directory and we are not anymore in a `.nvmrc` directory. See nvm-sh/nvm#2874
fdelacruz
pushed a commit
to fdelacruz/ohmyzsh
that referenced
this pull request
Mar 27, 2024
Now we only call `nvm version` in case we changed directory and we are not anymore in a `.nvmrc` directory. See nvm-sh/nvm#2874
pull bot
pushed a commit
to kis87988/ohmyzsh
that referenced
this pull request
Mar 27, 2024
Now we only call `nvm version` in case we changed directory and we are not anymore in a `.nvmrc` directory. See nvm-sh/nvm#2874
lukaselmer
pushed a commit
to lukaselmer/ohmyzsh
that referenced
this pull request
Apr 16, 2024
Now we only call `nvm version` in case we changed directory and we are not anymore in a `.nvmrc` directory. See nvm-sh/nvm#2874
8 tasks
ttelford
pushed a commit
to ttelford/oh-my-zsh
that referenced
this pull request
Jun 26, 2024
Now we only call `nvm version` in case we changed directory and we are not anymore in a `.nvmrc` directory. See nvm-sh/nvm#2874
naveen-u
pushed a commit
to naveen-u/ohmyzsh
that referenced
this pull request
Jul 1, 2024
Now we only call `nvm version` in case we changed directory and we are not anymore in a `.nvmrc` directory. See nvm-sh/nvm#2874
vladimir-kovalyov
pushed a commit
to vladimir-kovalyov/ohmyzsh
that referenced
this pull request
Mar 10, 2025
Now we only call `nvm version` in case we changed directory and we are not anymore in a `.nvmrc` directory. See nvm-sh/nvm#2874
stefc
pushed a commit
to stefc/ohmyzsh
that referenced
this pull request
May 2, 2025
Now we only call `nvm version` in case we changed directory and we are not anymore in a `.nvmrc` directory. See nvm-sh/nvm#2874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zsh hook in the readme causes
cdto take unnecessarily long when working in directory tress without.nvmrcfiles due to always callingnvm versionandnvm version default.We should only call
nvm versionandnvm version defaultif we left a directory with a.nvmrcfile.nvm_find_nvmrcandnvm_find_upare fast, so by creating a similar search, but withOLDPWD, unneeded calls tonvm versionandnvm version defaultare eliminated.