feat(typst): add textobjects#867
Open
anonymousgrasshopper wants to merge 2 commits intonvim-treesitter:mainfrom
Open
feat(typst): add textobjects#867anonymousgrasshopper wants to merge 2 commits intonvim-treesitter:mainfrom
anonymousgrasshopper wants to merge 2 commits intonvim-treesitter:mainfrom
Conversation
anonymousgrasshopper
force-pushed
the
feat/typst
branch
from
596de01 to
b5ebc57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds textobjects for typst.
All textobjects have been added, besides
@attribute.*,@class.*,@frame.*and@comment.inner.There is a tiny issue with
@function.inner: typst lambdas can either contain a block as their value or not, e.g.and
it => { // do stuff ... }are both valid, but
@function.innershouldn't match the braces in the second case (at least according to what is done for other languages). However, currently I match both with and without braces in the second case (instead of only without).It's my first time writing nontrivial tree-sitter queries, I haven't tested everything thoroughly, and I probably don't know all the syntax features of typst, so there might be some errors or omissions.