fix(builtin.buffers): improve only_cwd handling with partial matches#2845
Merged
Conversation
jamestrew
marked this pull request as draft
January 3, 2024 23:16
jamestrew
force-pushed
the
fix/buffers-cwd-only
branch
from
January 4, 2024 00:41
680728a to
e357f6b
Compare
closes #2843 Previously, bad partial matches between cwd and target buffer path would result in non-cwd buffers showing up in the picker despite using `only_cwd=true`. eg. cwd = `/foo/bar` target buffer = `foo/bar1/baz.txt` The target buffer starts with the cwd path. This is fixed by appending a path separator before comparing/matching: eg. cwd = `/foo/bar/` target buffer = `foo/bar1/baz.txt`
jamestrew
force-pushed
the
fix/buffers-cwd-only
branch
from
January 4, 2024 00:46
e357f6b to
2cd7960
Compare
jamestrew
marked this pull request as ready for review
January 4, 2024 00:48
|
Thanks @jamestrew |
Contributor
Author
|
@serranomorante great catch! |
|
Thank you so much @jamestrew everything works now 👍 |
Conni2461
pushed a commit
that referenced
this pull request
Mar 11, 2024
#2845) closes #2843 Previously, bad partial matches between cwd and target buffer path would result in non-cwd buffers showing up in the picker despite using `only_cwd=true`. eg. cwd = `/foo/bar` target buffer = `foo/bar1/baz.txt` The target buffer starts with the cwd path. This is fixed by appending a path separator before comparing/matching: eg. cwd = `/foo/bar/` target buffer = `foo/bar1/baz.txt` (cherry picked from commit c621f71)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2843
Previously, bad partial matches between cwd and target buffer path would result in non-cwd buffers showing up in the picker despite using
only_cwd=true.eg.
cwd =
/foo/bartarget buffer =
foo/bar1/baz.txtThe target buffer starts with the cwd path.
This is fixed by appending a path separator before comparing/matching: eg.
cwd =
/foo/bar/target buffer =
foo/bar1/baz.txt