feat(git_status): allow buffer_previewer_maker to receive options#2833
Merged
Conversation
so that previwer hooks work. For example, this avoids noisy previewer from binary files.
Conni2461
reviewed
Dec 30, 2023
Member
|
can you apply this to all |
Contributor
Author
|
Alright! Thank you for the suggestion. Should be okay now! |
Member
|
thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When peviewing new files with git_status, binary files show noises.
This is because the current previewer does not inherit global- or user-options.
My PR passes the option to previewer.
This can be considered as fix and new feature at the same time.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
Binary cannot be previewedmessage.Configuration:
Manjaro Linux
Checklist: