Skip to content

Conversation

@MunifTanjim
Copy link
Contributor

@MunifTanjim MunifTanjim commented Apr 17, 2022

Discussion: #265

@MunifTanjim MunifTanjim force-pushed the feat-mappings-disable-defaults branch from e365861 to 9e26e1e Compare April 17, 2022 18:15
Copy link
Contributor

@cseickel cseickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to express toggles in the positive sense, so I would go with either enable_default_mappings or use_default_mappings as the option name.

Between the two, I think use_default_mappings feels the most natural to me in this case. Would you agree?

@MunifTanjim MunifTanjim force-pushed the feat-mappings-disable-defaults branch from 9e26e1e to e5bd611 Compare April 18, 2022 06:18
cseickel
cseickel previously approved these changes Apr 18, 2022
@cseickel
Copy link
Contributor

The plenary tests might work for me because my packer setup already has those projects cloned to the correct location. If that's not true for you, something like what I do in the github action might work:

git clone https://github.com/MunifTanjim/nui.nvim ~/.local/share/nvim/site/pack/vendor/start/nui.nvim
git clone --depth 1 https://github.com/nvim-lua/plenary.nvim ~/.local/share/nvim/site/pack/vendor/start/plenary.nvim

It's ok though because you did fix the issue.

Thanks for contributing!

@cseickel cseickel merged commit fc1542e into nvim-neo-tree:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants