Tab completion for git paths

[Irubataru]

Contributing guidelines

• I have read CONTRIBUTING.md
• I have read CODE_OF_CONDUCT.md

Module(s)

mini.git

Description

Hiya 👋 I love your plugins, and was looking to mini.git to be a replacement for fugitive. I saw in the beta testing issue that Git show main:% could be used instead of Gedit, and that is true. What I was wondering is if it would be possible to get completion for paths in this command?

My use case is that sometimes I work in a repo and do changes where I refactor some class to be divided into other files, move things around, extract common code, etc.. Then, when I need to review the change, I can open the old (deleted) file with Gedit (or hopefully Git show), and diff it with whatever the new derived file is. It would then be a lot easier to have this workflow if we could tab complete paths after the git ref. I.e. Git show main:<Tab> instead of having to find the old path from the git log.

Thanks! ^^

[echasnovski]

Hello! Thanks for the suggestion!

Completions for :Git command are already quite complex, so I am not very optimistic that this will be added. But would like to know the use case better to have more info before deciding.

So do I understand correctly that you'd like to type :Git show main:, then press <Tab>, and see paths as candidates? And do I understand correctly that you also want to be able to see among completion suggestions files that are already deleted from disk?

My currently suggested "more interactive" solution would be to execute :Git diff. This shows in separate tabpage the patch (very manageable with folds from 'mini.git') which should include the deleted file. Placing a cursor on deleted file and executing show_at_cursor() will show its content as if :Git show :0:path/to/file, which I think would work. Fair warning, it doesn't seem to work on main, but it will be fixed after fixing #2063.

[Irubataru]

Yeah, you got it. Gedit does this, and I have always found it quite handy (and impressive) that it can tab complete the file tree as it was for the git ref you have prepended.

I tried your suggested approach (needed to do Git diff HEAD~5 as the file was deleted some commits ago), but becasue the above commit isn't merged into the main-git repo yet, I hope it's okay if I test it after. As far as I can see from opening other files, I think this interactive solution would solve my use-case, even if it is a few more steps 😊

[echasnovski]

I tried your suggested approach (needed to do Git diff HEAD~5 as the file was deleted some commits ago), but becasue the above commit isn't merged into the main-git repo yet, I hope it's okay if I test it after. As far as I can see from opening other files, I think this interactive solution would solve my use-case, even if it is a few more steps 😊

This should now work on latest main.

As making completion specifically for git show main: case specifically to enable this kind of workflow feels imbalanced (too much complexity, especially if deleted files need to be accounted for, for relatively niche use case), I am going to close this as not planned.

I'd still ask you to please follow up on whether the suggested "interactive solution" works for you.

[Irubataru]

I downloaded the update now and tested it out, and I am able to do my workflow ^^ Thanks!

I agree that it is a lot of work for something that might be niche (do people not diff against old deleted files?). Maybe there appears more use-cases in the future, but for now, I am happy with the alternate flow 😊