Change: rules_git_checkout handling branch names with slashes & Remote HEAD.#944
Merged
nvbn merged 2 commits intonvbn:masterfrom Sep 2, 2019
ik1ne:checkout-slashes
Merged
Change: rules_git_checkout handling branch names with slashes & Remote HEAD.#944nvbn merged 2 commits intonvbn:masterfrom ik1ne:checkout-slashes
nvbn merged 2 commits intonvbn:masterfrom
ik1ne:checkout-slashes
Conversation
- Change: Improved handling for branches with slash in their names.
Owner
|
Looks good, thanks! |
scorphus
added a commit
to scorphus/thefuck
that referenced
this pull request
Jul 14, 2021
scorphus
added a commit
to scorphus/thefuck
that referenced
this pull request
Jul 14, 2021
riley-martine
pushed a commit
to riley-martine/thefuck
that referenced
this pull request
Dec 7, 2023
…e HEAD. (nvbn#944) * Add: Test for branch names with slashes & Remote HEAD. * - Add: Handling for removing remote HEAD. - Change: Improved handling for branches with slash in their names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version of rule_git_checkout just returns line[-1] of split by '/', resulting to parsing branch names like 'release/1.2.3' to '1.2.3'.
Also, it does not consider remote head, thereby it will be duplicated when constructing list of branch names (although get_closest does not care about duplicates).