Skip to content

Conversation

@codeofdusk
Copy link
Contributor

Link to issue number:

None.

Summary of the issue:

Currently, in UIA consoles, invoking the "review start of line" script (shift+numpad 1 by default) does not move the review cursor.

Description of how this pull request fixes the issue:

Since expanding and collapsing the textInfo is essential for the functionality of this script (to move the textInfo to the start of the line), we should ignore the _expandCollapseBeforeReview flag.

Testing performed:

Tested that the script works as expected in UIA consoles on Windows 10 1903. Legacy consoles are unaffected (as they remain functional).

Known issues with pull request:

None.

Change log entry:

None.

@codeofdusk

This comment has been minimized.

@codeofdusk codeofdusk changed the base branch from beta to master July 17, 2019 16:13
@feerrenrut feerrenrut self-requested a review July 26, 2019 13:20
@feerrenrut
Copy link
Contributor

When is the _expandCollapseBeforeReview flag typically set / not set. Why is it the case?

@codeofdusk
Copy link
Contributor Author

When is the _expandCollapseBeforeReview flag typically set / not set. Why is it the case?

The _expandCollapseBeforeReview flag was added in #9614. It is True everywhere except in UIA consoles.
For historical reasons, the review cursor collapses and expands textInfos during movement. However, on Windows 10 1903 this caused problems with review (since collapse was broken). This was fixed in #9802. See the comments in NVDAObjects/UIA/winConsoleUIA.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants