-
-
Notifications
You must be signed in to change notification settings - Fork 748
Handle aria-current=false as False instead of True #7901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
abdd6dc
604861c
f3fcbda
5c11b86
31d90a2
6276d9b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -458,7 +458,7 @@ def _get_ariaProperties(self): | |
| # in a list of strings like "something=true;current=date;". We want to capture one group, after the '=' | ||
| # character and before the ';' character. | ||
| # This could be one of: True, "page", "step", "location", "date", "time" | ||
| RE_ARIA_CURRENT_PROP_VALUE = re.compile("current=(\w+);") | ||
| RE_ARIA_CURRENT_PROP_VALUE = re.compile("current=(?!false)(\w+);") | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This regex seems a bit broken:
May be we need a unit test for this. cc @feerrenrut |
||
|
|
||
| def _get_isCurrent(self): | ||
| ariaProperties=self._getUIACacheablePropertyValue(UIAHandler.UIA_AriaPropertiesPropertyId) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -821,7 +821,7 @@ def _get_statusBar(self): | |
| def _get_isCurrent(self): | ||
| """Gets the value that indicates whether this object is the current element in a set of related | ||
| elements. This maps to aria-current. Normally returns False. If this object is current | ||
| it will return one of the following values: True, "page", "step", "location", "date", "time" | ||
| it will return one of the following values: "true", "page", "step", "location", "date", "time" | ||
| """ | ||
| return False | ||
|
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update this comment to add "false" as a valid value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also double checked in edge.
Trueshould be listed as "true"