Disable caret events in all terminal programs #10118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
You have talked about the testing in Putty and the intended changed in behavior in Mintty, but this change affects all terminals. What have you done to verify there are no regressions elsewhere (cmd, older OS)? |
Contributor
|
When testing for regressions don't forget SSH clients such as SecureCRT, Tera Term. |
Collaborator
|
Note that this pr restores the behaviour of terminals to the situation before #9933, so I don't think we have to be afraid of any major regressions here. |
LeonarddeR
approved these changes
Aug 21, 2019
Contributor
Author
Correct. |
feerrenrut
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #1348.
Related to #9933, #9986.
Summary of the issue:
In Mintty, the last character of the prompt is read when quickly deleting text, just as in Windows Console (see this comment and the "summary of the issue" section in #9986).
Description of how this pull request fixes the issue:
This PR disables caret events for all
Terminalobjects by overridingNVDAObjects.behaviors.Terminal._get_caretMovementDetectionUsesEvents, instead of only Windows Console like in #9986.Testing performed:
Tested the steps to reproduce from #1348 in PuTTY and observed that extra characters are no longer read. Verified that caret movement and backspace reporting are still functional in PuTTY after the changes.
Known issues with pull request:
None.
Change log entry:
None (py3 regression).