Skip to content

Conversation

@codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Aug 8, 2019

Link to issue number:

Fixes #10030. Related to #9614.

Summary of the issue:

NVDA incorrectly reports an empty selection when focusing Windows consoles.

Since the TextInfo property on consoles was prefixed with an underscore, NVDA dynamically selected the wrong TextInfo implementation (see NVDAObjects.UIA.UIA._getTextInfo). This means that when a console is first focused, UIATextInfo is selected instead of WinConsoleUIA.TextInfo, so our patched isCollapsed logic isn't used and speech.speakPreselectedText is called (see lines 391–393 in speech/__init__.py).

Description of how this pull request fixes the issue:

Assign the textInfo class as WinConsoleUIA.TextInfo rather than WinConsoleUIA._TextInfo.

Testing performed:

Tested steps from the issue and confirmed that no superfluous selections are reported.

Known issues with pull request:

None.

Change log entry:

None.

@codeofdusk
Copy link
Contributor Author

Cc @feerrenrut @LeonarddeR

@LeonarddeR LeonarddeR requested a review from feerrenrut August 8, 2019 11:59
@AppVeyorBot
Copy link

PR introduces Flake8 errors 😲

See test results for Failed build of commit d7784c33fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repetition when focusing a console window

5 participants