Skip to content

fix: improve websocket and watcher cleanup handling #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farnabaz merged 2 commits into from
Aug 5, 2025
Merged

fix: improve websocket and watcher cleanup handling #3478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4c89f8
fix: improve websocket and watcher cleanup handling
productdevbook Jul 24, 2025
c08fbde
chore: update
productdevbook Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/utils/dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,13 @@ export async function startSocketServer(nuxt: Nuxt, options: ModuleOptions, mani

nuxt.hook('close', async () => {
// Close WebSocket server
await websocket?.close()
await listener?.server?.close()
if (websocket) {
await websocket.close()
}
// Close listener server
if (listener) {
await listener.close()
}
})
}

Expand Down Expand Up @@ -211,8 +216,11 @@ export async function watchContents(nuxt: Nuxt, options: ModuleOptions, manifest
}

nuxt.hook('close', async () => {
watcher.close()
db.close()
if (watcher) {
watcher.removeAllListeners()
watcher.close()
db.close()
}
})
}

Expand Down