chore: add sql_dump file extension
#3339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #3337
β Type of change
π Description
Add
sql_dumproutes url file extension.txt(including tests). In version3.5.0was explicitly set dump's content type totext/plain(#3302). It will be good practice to set the dump file extension to.txt.It is known that files without extension in AWS Amplify does not work: aws-amplify/amplify-hosting#225
When you manual deploy a Nuxt project to AWS Amplify, in local environment build the project with
nuxt generate. Thesql_dumpfile is pre-rendered without a file extension.If
sql_dumpfile is uploaded without extension to AWS Amplify, the environment will delete it, causing a 404 error, whensql_dumpfile is fetched.Resolves #3337
π Checklist