Skip to content

Cosmetic refactor transformations #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
esc merged 3 commits into from
Mar 29, 2023
Merged

Cosmetic refactor transformations #26

esc merged 3 commits into from
Mar 29, 2023

Conversation

@esc
Copy link
Member

@esc esc commented Mar 29, 2023 •
edited
Loading

As title. Variable name changes and reformatting.

esc added 3 commits March 29, 2023 14:04
@esc
refactor find_head_blocks
779b0cb 
Rename the variable that is bound to the outgoing edges and use the list
indexing to access the elements.
@esc
refactor find_branch_regions
951a837 
As title
@esc
refactor loop_restructure_helper
4647610 
As title
@esc esc requested a review from kc611 March 29, 2023 12:17
kc611
kc611 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@kc611 kc611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@esc esc merged commit a57b137 into numba:main Mar 29, 2023
@esc esc deleted the cosmetic_refactor_transformations branch March 29, 2023 12:46
esc added a commit to esc/numba-scfg that referenced this pull request Mar 31, 2023
@esc
fix two bugs leftover from refactoring
58054c3 
This fixes two bugs on `main` introduced by:

* numba#26

and

* numba#28

It's probably a sign that the test coverage isn't high enough yet.
@esc esc mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kc611 kc611 kc611 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@esc @kc611