Replace CAtom's bitfield with packed struct#243
Closed
frmdstryr wants to merge 2 commits intonucleic:mainfrom
Closed
Replace CAtom's bitfield with packed struct#243frmdstryr wants to merge 2 commits intonucleic:mainfrom
frmdstryr wants to merge 2 commits intonucleic:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 24 24
Lines 1074 1074
Branches 162 162
=======================================
Hits 1049 1049
Misses 12 12
Partials 13 13 🚀 New features to boost your workflow:
|
bd72b02 to
8196ead
Compare
MatthieuDartiailh
previously approved these changes
Feb 4, 2025
Contributor
Author
|
I made one more micro optimization.... In CAtom_new it currently calls I haven't looked if the compiler is smart enough to optimize it into a single write or not but this way it should only ever be one write. Edit: I was curious Current behavior: https://godbolt.org/z/P9zK9eEbK so it removes a single 'or' instruction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce manual bit fiddling...