Skip to content

Return error if num args is incorrect in parse_mod_and_context #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sccolbert merged 1 commit into from
Jan 21, 2025
Merged

Return error if num args is incorrect in parse_mod_and_context #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions atom/src/member.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,10 @@ parse_mode_and_context( PyObject*const *args, Py_ssize_t n, PyObject** context,
{

if( n != 2 )
{
cppy::type_error( "set mode requires two arguments mode, context" );
return false;
}
if( !EnumTypes::from_py_enum( args[0], mode ) )
return false;
*context = args[1];
Expand Down
9 changes: 9 additions & 0 deletions tests/test_get_behaviors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,3 +174,12 @@ class SlotAtom(Atom):

with pytest.raises(AttributeError):
SlotAtom.v.do_getattr(sa)


def test_using_invalid_args():
"""Test using the invalid arguments."""
v = Value()
with pytest.raises(TypeError):
v.set_getattr_mode(None)
with pytest.raises(TypeError):
v.set_getattr_mode(7, None)
Loading