Update member.cpp to use fastcalls#231
Merged
MatthieuDartiailh merged 3 commits intonucleic:mainfrom Jan 20, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 24 24
Lines 1074 1074
Branches 162 162
=======================================
Hits 1049 1049
Misses 12 12
Partials 13 13 |
sccolbert
reviewed
Jan 20, 2025
sccolbert
requested changes
Jan 20, 2025
Member
sccolbert
left a comment
There was a problem hiding this comment.
Most of this is a good change and is easy to reason about. I would prefer the changes to parse_mode_and_context to be a separate change with a corresponding reason.
7d045c2 to
bde09d9
Compare
sccolbert
approved these changes
Jan 20, 2025
Contributor
Author
|
Thanks for reviewing all these PRs! Hopefully it makes everyone's code a little faster. The only other thing I can think of possibly updating yet would be changing any of the tp_call's to use vectorcallfunc but i'm not sure how to do that yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
Member_set_x_modefunctionscppy::replacedoes an XINCREF even though it's already checked.