Refactor delattrbehavior calls

[frmdstryr]

Same thing for delattr

[sccolbert]

I thought about this before I approved the changes, but the attribute exception error I think would be "sufficient enough" since it would be something like "object has no attribute `_del_foo`".

…

On Sat, Jan 18, 2025 at 11:57 AM Matthieu Dartiailh < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In atom/src/delattrbehavior.cpp <#225 (comment)>: > @@ -155,17 +155,7 @@ _mangled_property_handler( Member* member, CAtom* atom ) cppy::ptr name( PyUnicode_FromFormat( "_del_%s", suffix ) ); if( !name ) return -1; - cppy::ptr callable( PyObject_GetAttr( pyobject_cast( atom ), name.get() ) ); - if( !callable ) - { - if( PyErr_ExceptionMatches( PyExc_AttributeError ) ) - PyErr_SetString( PyExc_AttributeError, "can't delete attribute" ); Losing this means we lose on the quality of the error message. It is sad we cannot preserve it while improving performance. Would creating the method and then calling it with a better PyObject_Call make it much worse than the current solution. — Reply to this email directly, view it on GitHub <#225 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABBQSI5FYJL6VWHPUFFDGL2LKIYNAVCNFSM6AAAAABVN2NHTGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRQGQ4TEOJVGA> . You are receiving this because you commented.Message ID: ***@***.***>

[frmdstryr]

Looks ok to me if I did this right..

In [23]: class A(Atom):
    ...:     y = 1
    ...:     def  _get_x(self):
    ...:         return self.y
    ...:     x = Property()
    ...: 

In [24]: A.x.set_delattr_mode(DelAttr.Property, None)

In [25]: a = A()

In [26]: a.x
Out[26]: 1

In [27]: del a.x
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[27], line 1
----> 1 del a.x

AttributeError: 'A' object has no attribute '_del_x'

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (32bedfe) to head (735042e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          24       24           
  Lines        1074     1074           
  Branches      162      162           
=======================================
  Hits         1049     1049           
  Misses         12       12           
  Partials       13       13