Refactor getattrbehavior to avoid allocations

[frmdstryr]

Same as #223 but separate PR to make it easier to review.

[frmdstryr]

I think if catom is updated to use the fastcall protocol more optimizations can be done here (with created_args).

[frmdstryr]

Could the mangled name _get_%s somehow be cached instead of reformatting it every time?

[sccolbert]

Could the mangled name _get_%s somehow be cached instead of reformatting it every time?

Can you link to a line number where you mean?

[frmdstryr]

Here https://github.com/nucleic/atom/blob/main/atom/src/getattrbehavior.cpp#L161

Idk if the getattr_context can be repurposed to store the name?

Edit: Or better yet the method itself

[sccolbert]

I don't think that's worth the tradeoff. The Property members aren't used very often, and while they could benefit from some more storage for caching, that would complicate the entire Member struct, which tries to be as space-efficient as possible.

When I originally wrote atom, it was for a commercial purpose sponsored by my employer. In that setting, optimizing memory use was the main driver. They have a very large codebase with tens of millions of Python objects instantiated at any given time. Since they are still using the library AFAIK, I don't want to make changes that would explode memory usage for them.

[MatthieuDartiailh]

This is a very nice diff !

[MatthieuDartiailh]

I will restart the CIs later (the API rate limits for external contributor is so annoying) and merge when they come back green.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (1dc853d) to head (2b59255).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          24       24           
  Lines        1074     1074           
  Branches      162      162           
=======================================
  Hits         1049     1049           
  Misses         12       12           
  Partials       13       13