Change range/float range to value error and include member/obj in error message#221
Merged
MatthieuDartiailh merged 4 commits intonucleic:mainfrom Jan 20, 2025
Conversation
Contributor
Author
|
Well it seems something changed in the float_range_handler with 3.12. I started getting 'too small' validation errors with |
Contributor
Author
|
If I change low value to a float |
Member
|
Can you rebase on main to fix the CI issue. Also it may be worth casting the low, high to preserve the fast validation path. |
2a6fa7e to
db719dc
Compare
db719dc to
e8ff667
Compare
e8ff667 to
aa1dd73
Compare
b69a936 to
699e66f
Compare
Contributor
Author
|
The problem was there was no context validation for FloatRangePromote since the case was missing. |
MatthieuDartiailh
previously approved these changes
Jan 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 97.27% 97.67% +0.39%
==========================================
Files 24 24
Lines 1065 1074 +9
Branches 158 162 +4
==========================================
+ Hits 1036 1049 +13
+ Misses 14 12 -2
+ Partials 15 13 -2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a value out of range throws a type error even if it is the correct type.
This also includes the member name in the error message.