Fix memory leak in pickle creation#213
Merged
MatthieuDartiailh merged 10 commits intomainfrom Jul 4, 2024
Merged
Conversation
The reason for the changes around __slotnames__ are not clear to me but are necessary
(cherry picked from commit 32ce246618d7adb3b1560f788b299f3657726ca1)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 97.67% 97.66% -0.02%
==========================================
Files 24 24
Lines 1075 1070 -5
Branches 174 174
==========================================
- Hits 1050 1045 -5
Misses 12 12
Partials 13 13 |
MatthieuDartiailh
added a commit
that referenced
this pull request
Jul 4, 2024
* fix a memory leak related to pickling Atom subclasses The reason for the changes around __slotnames__ are not clear to me but are necessary * cis: fix ruff invocation * tests: update test so that it does show an improvement over main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue is weird. The test added is not truly representative which bothers me a lot, but I have a large use case in which it does fix an issue. I will try to understand better the root issue before merging.