Skip to content

fix: use URL.canParse instead of runtime deprecated url.parse api #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wraithgar merged 2 commits into from
Jul 22, 2025
Merged

fix: use URL.canParse instead of runtime deprecated url.parse api #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e9de94
fix: use `URL.canParse` instead of runtime deprecated `url.parse` api
SuperchupuDev Jul 22, 2025
12a3eb8
chore: import `URL` from `node:url`
SuperchupuDev Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions lib/normalize-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Originally normalize-package-data

const url = require('node:url')
const { URL } = require('node:url')
const hostedGitInfo = require('hosted-git-info')
const validateLicense = require('validate-npm-package-license')

Expand Down Expand Up @@ -123,8 +123,7 @@ function normalizeData (data, changes) {
if (typeof data.bugs === 'string') {
if (isEmail(data.bugs)) {
data.bugs = { email: data.bugs }
/* eslint-disable-next-line node/no-deprecated-api */
} else if (url.parse(data.bugs).protocol) {
} else if (URL.canParse(data.bugs)) {
data.bugs = { url: data.bugs }
} else {
changes?.push(`Bug string field must be url, email, or {email,url}`)
Expand All @@ -140,8 +139,7 @@ function normalizeData (data, changes) {
const oldBugs = data.bugs
data.bugs = {}
if (oldBugs.url) {
/* eslint-disable-next-line node/no-deprecated-api */
if (typeof (oldBugs.url) === 'string' && url.parse(oldBugs.url).protocol) {
if (URL.canParse(oldBugs.url)) {
data.bugs.url = oldBugs.url
} else {
changes?.push('bugs.url field must be a string url. Deleted.')
Expand Down Expand Up @@ -216,8 +214,7 @@ function normalizeData (data, changes) {
changes?.push('homepage field must be a string url. Deleted.')
delete data.homepage
} else {
/* eslint-disable-next-line node/no-deprecated-api */
if (!url.parse(data.homepage).protocol) {
if (!URL.canParse(data.homepage)) {
data.homepage = 'http://' + data.homepage
}
}
Expand Down
Loading