Save on reversion #140
Merged
Save on reversion #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a package.json is changed, saved, and then reverted back to what it was before, save was not running because this module was not updating its local copy of what the contents of the file was. This has been fixed.
hashtagchris
approved these changes
Jan 15, 2025
Merged
wraithgar
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- ## [6.1.1](v6.1.0...v6.1.1) (2025-01-21) ### Bug Fixes * [`526473b`](526473b) [#139](#139) remove max-len linting bypasses (@wraithgar) * [`2a7bbe5`](2a7bbe5) [#139](#139) inline normalize-package-data logic (@wraithgar) * [`2d320bc`](2d320bc) [#140](#140) save when reverting content (@wraithgar) ### Dependencies * [`6ea3a9d`](6ea3a9d) [#139](#139) add `[email protected]` * [`35152b6`](35152b6) [#139](#139) remove normalize-package-data ### Chores * [`0930f4e`](0930f4e) [#139](#139) `@npmcli/[email protected]` (@wraithgar) * [`1464adc`](1464adc) [#140](#140) scope test fixture package names (@wraithgar) * [`d722a1f`](d722a1f) [#137](#137) bump @npmcli/template-oss from 4.23.5 to 4.23.6 (#137) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a package.json is changed, saved, and then reverted back to what it was before, save was not running because this module was not updating its local copy of what the contents of the file was. This has been fixed.
This also updates the test fixture package names to be scoped.
References
Closes: #138