Omit filenames containing asterisks #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filenames containing * chars break windows and create incompatible archives in the npm registry. In the next major release, this should raise an error instead of silently omitting them, so that authors can be alerted. Fix #9
maxwellgerber
added a commit
to maxwellgerber/cli
that referenced
this pull request
Jun 2, 2020
In npm/npm-packlist#32, NPM started to drop filenames containing the `*` character. See: - npm#1096 - npm#1048
claudiahdz
pushed a commit
to npm/cli
that referenced
this pull request
Jun 24, 2020
In npm/npm-packlist#32, NPM started to drop filenames containing the `*` character. See: - #1096 - #1048 PR-URL: #1377 Credit: @maxwellgerber Close: #1377 Reviewed-by: @claudiahdz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filenames containing * chars break windows and create incompatible
archives in the npm registry.
In the next major release, this should raise an error instead of
silently omitting them, so that authors can be alerted.
Fix #9