Skip to content

Conversation

@SuperchupuDev
Copy link
Contributor

Remember #224? Since this package no longer supports anything below node 18.6.0, we can switch to isBuiltin instead, as originally suggested in my previous PR.

References

https://nodejs.org/api/module.html#moduleisbuiltinmodulename

@SuperchupuDev SuperchupuDev requested a review from a team as a code owner June 28, 2025 23:38
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up!

@wraithgar wraithgar merged commit cc37f25 into npm:main Jul 10, 2025
20 checks passed
@github-actions github-actions bot mentioned this pull request Jul 10, 2025
@SuperchupuDev SuperchupuDev deleted the fix/is-builtin branch July 10, 2025 22:21
wraithgar pushed a commit that referenced this pull request Jul 22, 2025
🤖 I have created a release *beep* *boop*
---


##
[7.0.1](v7.0.0...v7.0.1)
(2025-07-22)
### Bug Fixes
*
[`97fb20a`](97fb20a)
[#247](#247) use
`URL.canParse` instead of runtime deprecated `url.parse` api (#247)
(@SuperchupuDev)
*
[`cc37f25`](cc37f25)
[#244](#244) use
`isBuiltin` instead of `builtinModules` (#244) (@SuperchupuDev)
### Chores
*
[`acafa71`](acafa71)
[#245](#245) bump
@npmcli/template-oss from 4.24.4 to 4.25.0 (#245) (@dependabot[bot],
@owlstronaut)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants