Sorted tarball contents

[eridal]

This will make npm pack output the tarball contents
in an alphabetically and natural sort order.

The current implementation uses localeCompare with
the following options:

1. sensitivity: base, to correctly handle non-ascii letters
   using their base ascii, so that á,â, ä, ã, å are
   all handled like a

2. numbers: true, to handle numeric filenames as natural
   ascending order so that, for instance, file 10.txt appears after 9.txt

---

Convo from npm/rfcs#96

cc @ruyadorno @ isaacs

[eridal]

Hmmm those tests are failing with EXDEV: cross-device link not permitted, which means that fs.rename(src, dst) failed due to src and dst being on different devices, like C:\ and D:\

The right way to fix that seems to me way out of the scope of this PR

Any pointers?

[ruyadorno]

hi @eridal thanks for the contribution! this looks great ❤️

now one very small change I'd like to ask - I know the GitHub web interface order files in such a way that capitalized letters come first (I think it comes from some sort of unix standard but I'm really not sure about it, don't quote me on that heheheh) anyways, the point is that's a standard that people got used to and it would be nice if we could replicate the same thing here 😊

[eridal]

@ruyadorno thanks for your feedback

Yes, at first that was the order I had set in place. Then I thought that given different OSes have different standards (ie: case vs icase, folders first, ...) the more inclusive approach would be to sort naturally.

But now that you mentioned, using the same listing order than Github really makes sense to me!

[eridal]

Hmm I did not like much the way it ended up being, but if I'm reading correctly the standard for localeCompare we cannot sort this as a single operation.

What I'm seeing is that using caseFirst with values upper or lower will yield orders AaBbCcDd.. and aAbBcCdD... respectively.

Given that we want ABCD..XYZabc...xyz then the only option (that I see) is to solve this in a two-steps process.

Please let me know your thoughts about this

https://www.ecma-international.org/ecma-402/1.0/#CompareStrings

[eridal]

It is quite sad how standard makes writing such common idioms in a broken way, compare this:

-    return ch >= 'A' && ch <= 'Z'
+    return 'A' <= ch && ch <= 'Z'

[claudiahdz]

Hi @eridal! You caught us there in an unstable state when you created this PR. I manually included your changes and pushed them to latest. Thank you for your contribution!