Skip to content

fix: code cleanup #8677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wraithgar merged 12 commits into from
Oct 16, 2025
Merged

fix: code cleanup #8677

wraithgar merged 12 commits into from
Oct 16, 2025

Conversation

@wraithgar
Copy link
Member

@wraithgar wraithgar commented Oct 15, 2025

Smaller version of #8675 without the code rollups.

  • constructor logic was consolidated. It takes place in the main Arborist constructor when possible, allowing us to see all of the constructor at once and find any duplications or problems. It's evident that our approach to options/this.options needs some attention.
  • Some small single-use methods were inlined into the code that called them. In many cases this prevented re-pulling variables from this.
  • remove unused param from call to #linkFromSpec. The function is not expecting a fourth parameter.
  • remove unused private attributes, #dryRun and #savePrefix are not used anymore

@wraithgar wraithgar requested a review from a team as a code owner October 15, 2025 19:57
@wraithgar
move public build-ideal-tree constructor code to main class
0e6a14e
@wraithgar
consolidate constructors
d691575 
move everything public to Arborist
move everything "private" and shared to build-ideal-tree
remove #resetQueues in favor of an initial value and explicit reset
@wraithgar
remove unused param from function call
b38b772
@wraithgar
move usePackageLock to this.options
075d770
@wraithgar wraithgar force-pushed the gar/arborist-cleanup branch from ad64a4a to fe38984 Compare October 15, 2025 20:49
@wraithgar
skip node.optional check for optionalSet
19ed12c 
Both times we call this we are already checking this, no need to do it twice
@wraithgar
inline #resolveNodes
6cfc70d
@wraithgar
inline #linkFromSpec
24dd64e
@wraithgar
add comment
f66fc62
@wraithgar wraithgar force-pushed the gar/arborist-cleanup branch from fe38984 to f66fc62 Compare October 15, 2025 20:52
@wraithgar wraithgar merged commit 05319f0 into latest Oct 16, 2025
16 checks passed
@wraithgar wraithgar deleted the gar/arborist-cleanup branch October 16, 2025 01:30
@github-actions github-actions bot mentioned this pull request Oct 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owlstronaut owlstronaut owlstronaut approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wraithgar @owlstronaut