Skip to content

feat: npm view oidc considerations #8432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reggi merged 2 commits into from
Jul 14, 2025
Merged

feat: npm view oidc considerations #8432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ce7102
feat: npm view for oidc
reggi Jul 11, 2025
6d653a5
test
reggi Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/commands/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,10 +448,12 @@ function cleanup (data) {
}

const keys = Object.keys(data)

if (keys.length <= 3 && data.name && (
(keys.length === 1) ||
(keys.length === 3 && data.email && data.url) ||
(keys.length === 2 && (data.email || data.url))
(keys.length === 2 && (data.email || data.url)) ||
data.trustedPublisher
)) {
data = unparsePerson(data)
}
Expand Down
34 changes: 34 additions & 0 deletions test/lib/commands/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,34 @@ const packument = (nv, opts) => {
'1.0.1': {},
},
},
'cyan-oidc': {
_npmUser: {
name: 'claudia',
email: '[email protected]',
trustedPublisher: {
id: 'github',
oidcConfigId: 'oidc:a0e127d0-8d66-45d0-8264-e4f8372c7249',
},
},
name: 'cyan',
'dist-tags': {
latest: '1.0.0',
},
versions: {
'1.0.0': {
version: '1.0.0',
name: 'cyan',
dist: {
shasum: '123',
tarball: 'http://hm.cyan.com/1.0.0.tgz',
integrity: '---',
fileCount: 1,
unpackedSize: 1000000,
},
},
'1.0.1': {},
},
},
brown: {
name: 'brown',
},
Expand Down Expand Up @@ -438,6 +466,12 @@ t.test('package with --json and semver range', async t => {
t.matchSnapshot(joinedOutput())
})

t.test('package with _npmUser.trustedPublisher shows cleaned up property with --json', async t => {
const { view, joinedOutput } = await loadMockNpm(t, { config: { json: true } })
await view.exec(['cyan-oidc@^1.0.0'])
t.match(joinedOutput(), /claudia <[email protected]>/, 'uses oidc trustedPublisher info for _npmUser')
})

t.test('package with --json and no versions', async t => {
const { view, joinedOutput } = await loadMockNpm(t, { config: { json: true } })
await view.exec(['brown'])
Expand Down
Loading