fix(arborist): workspaces correctly path to file: packages from over… #8206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlstronaut
force-pushed
the
owlstronaut/5584
branch
from
cf2a477 to
bdbc1ad
Compare
owlstronaut
changed the title
wraithgar
reviewed
Apr 7, 2025
owlstronaut
force-pushed
the
owlstronaut/5584
branch
from
1e3ce57 to
94b4166
Compare
wraithgar
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5584
This pull request introduces changes to the
Reifierclass inworkspaces/arborist/lib/arborist/reify.jsto handle root overrides withfile:paths and adds a corresponding test case. The most important changes include the addition of a new method to calculate relative paths and the inclusion of a test to verify the new functionality.I learned about how windows does symlinks in this (junctions). Interesting difference.