edit: scoped packages

[larsgw]

• handle scoped packages properly
• change usage info so it matches old (and current) behavior.

There's an easier way to do this, but that handles some edge cases differently (namely, ignore leading and trailing forward slashes instead of trying to edit root folders), and I don't know if that is allowed.

diff --git a/lib/edit.js b/lib/edit.js
index 48bcd5d34..2b2a02224 100644
--- a/lib/edit.js
+++ b/lib/edit.js
@@ -21,7 +21,7 @@ function edit (args, cb) {
       "No editor set.  Set the 'editor' config, or $EDITOR environ."
     ))
   }
-  p = p.split('/')
+  p = (p.match(/(@[^/]+\/[^/]+|[^/]+)/g) || [])
     .join('/node_modules/')
     .replace(/(\/node_modules)+/, '/node_modules')
   var f = path.resolve(npm.dir, p)

See https://npm.community/t/2258.

[iarna]

A small doc update to do here, either by @larsgw or when we land this. Otherwise, yes, let's get this in!

[iarna]

I looked into how this summary got messed up, and it goes back to the edit docs having been wrong since 2011, and folks patching this usage summary to match them.

I would like to see the summary in doc/cli/npm-edit.md updated to match!

[larsgw]

Will do, didn't see those were in the repo too.

[iarna]

Ordinarily I'd ask for tests, but we don't have any existing tests for this route, this is a interactive route and this change is reasonably eyeballable, so I'm inclined to take this without them.

[larsgw]

Yeah, I tried making tests but I'm not too familiar with all the mocking environments yet, and without something to work with I wasn't sure how to.

[larsgw]

Ping? I added the docs, is there something else?