fix(reify): cleanup of Symbols #7430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts the long process of cleaning reify.js up. All of the remaining symbols are used either elsewhere in arborist, or in tests. A single use function was inlined, and `dedupe` was moved to the main arborist class.
wraithgar
force-pushed
the
gar/arborist-cleanup
branch
from
abd2fe3 to
7df7bbc
Compare
ljharb
reviewed
Apr 26, 2024
lukekarrys
approved these changes
Apr 30, 2024
Contributor
lukekarrys
left a comment
lukekarrys
left a comment
There was a problem hiding this comment.
This represents a ton of work that will be very beneficial going forward! 👏🏼
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts the long process of cleaning reify.js up. All of the
remaining symbols are used either elsewhere in arborist, or in tests.
A single use function was inlined, and
dedupewas moved to the mainarborist class.